On 04/04/2022 23:57, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@xxxxxxxxxxx>
>
> Create dt-binding documentation to document rk817 battery and charger
> usage. New device-tree properties have been added.
>
> - rockchip,resistor-sense-micro-ohms: The value in microohms of the
> sample resistor.
> - rockchip,sleep-enter-current-microamp: The value in microamps of the
> sleep enter current.
> - rockchip,sleep-filter-current: The value in microamps of the sleep
> filter current.
>
> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx>
> ---
> .../bindings/mfd/rockchip,rk817.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> index bfc1720adc43..b949d406a487 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> @@ -117,6 +117,47 @@ properties:
> description:
> Describes if the microphone uses differential mode.
>
> + battery:
I wonder why do you call it a batter while it is a charger, isn't it?
> + description: |
> + The child node for the charger to hold additional properties. If a
> + battery is not in use, this node can be omitted.
> + type: object
> + properties:
> + monitored-battery:
> + description: |
> + A phandle to a monitored battery node that contains a valid
> + value for:
> + charge-full-design-microamp-hours,
> + charge-term-current-microamp,
> + constant-charge-current-max-microamp,
> + constant-charge-voltage-max-microvolt,
> + voltage-max-design-microvolt,
> + voltage-min-design-microvolt,
> + and a valid ocv-capacity table.
> +
> + rockchip,resistor-sense-micro-ohms:
> + description: |
> + Value in microohms of the battery sense resistor. This value is
> + used by the driver to set the correct divisor value to translate
> + ADC readings into the proper units of measure.
> + enum: [10000, 20000]
> +
> + rockchip,sleep-enter-current-microamp:
> + description: |
> + Value in microamps of the sleep enter current for the charger.
> + Value is used by the driver to calibrate the relax threshold.
> +
> + rockchip,sleep-filter-current-microamp:
> + description:
> + Value in microamps of the sleep filter current for the charger.
> + Value is used by the driver to derive the sleep sample current.
> +
> + required:
> + - monitored-battery
> + - rockchip,resistor-sense-micro-ohms
> + - rockchip,sleep-enter-current-microamp
> + - rockchip,sleep-filter-current-microamp
> +
> allOf:
> - if:
> properties:
> @@ -323,6 +364,13 @@ examples:
> };
> };
>
> + rk817_battery: battery {
The same.
> + monitored-battery = <&battery_cell>;
> + rockchip,resistor-sense-micro-ohms = <10000>;
> + rockchip,sleep-enter-current-microamp = <300000>;
> + rockchip,sleep-filter-current-microamp = <100000>;
> + };
> +
> rk817_codec: codec {
> rockchip,mic-in-differential;
> };
Best regards,
Krzysztof
