On Sat, 2022-04-02 at 13:31 +0200, Krzysztof Kozlowski wrote: > On 01/04/2022 15:39, Jia-Wei Chang wrote: > > > > > > > > > > > + > > > > > > + operating-points-v2: > > > > > > + description: > > > > > > + For details, please refer to > > > > > > + Documentation/devicetree/bindings/opp/opp-v2.yaml > > > > > > + > > > > > > + opp-table: true > > > > > > > > > > Same comments as your CPU freq bindings apply. > > > > > > > > mtk-cci-devfreq is a new driver and its arch is same as > > > > mediatek- > > > > cpufreq so that the properties of mtk-cci are refer to > > > > mediatek- > > > > cpufreq > > > > bindings. > > > > operating-point-v2 is used to determine the voltage and > > > > frequency > > > > of > > > > dvfs which is further utilized by mtk-cci-devfreq. > > > > > > "operating-point-v2" is understood, but the same as in cpufreq > > > bindings, > > > I am questioning why do you have "opp-table: true". It's a bit > > > confusing, so maybe I miss something? > > > > Yes, you're correct. > > "opp-table: true" should be removed. > > I messed it up. > > No, I think I was wrong. The opp-table pretty frequently is embedded > in > the the device node itself. The operating-points-v2 references it. > > You don't use it in the example, but it might be a valid usage, so it > can stay. Sorry for the confusion, it passed some time since I looked > at > OPP bindings. You remind me of "opp-table: true" and the reason why I use it here is exactly as you mentioned. Sorry I was not familiar enough with this to respond it clearly and confidently. I think it is proper to keep "opp-table: true" and add a complete opp table information in dts example here as well. Thanks for your comments. > > > Best regards, > Krzysztof
