On Tue, Apr 05, 2022 at 09:20:24AM +0200, Miquel Raynal wrote: > Hello, > > gch981213@xxxxxxxxx wrote on Tue, 5 Apr 2022 10:55:51 +0800: > > > Hi Rob! > > > > On Tue, Apr 5, 2022 at 12:09 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > [...] > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml: spi@1100d000: 'ecc-engine' is a required property > > > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > > > Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml:0:0: /example-0/soc/spi@1100d000/flash@0: failed to match any schema with compatible: ['spi-nand'] > > > > I ran the tests myself and it's only complaining about the ecc-engine name: > > > > /home/user/src/kernels/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dtb: > > spi@1100d000: 'ecc-engine' is a required property > > From schema: /home/user/src/kernels/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > > > > It says nothing about the spi-nand part. Did you use 'DT_CHECKER_FLAGS=-m' as it says above? > > I'd like to keep the flash@0 node in the example to demonstrate the > > nand-ecc-engine usage. What should I do? > > You can try including spi-nand.yaml (like you do with > spi-controller.yaml). You should no longer need to define > nand-ecc-engine then as it is already described there? Including spi-nand.yaml is wrong. If that just landed, then this may have run before the base moved to v5.18-rc1. Rob
