Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25) > Add gcc hardware reset entries for eMMC and SD card. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index c07765d..cd50ea3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -881,6 +881,10 @@ > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > > + /* gcc hardware reset entry for eMMC */ Please don't add this worthless comment. > + resets = <&gcc GCC_SDCC1_BCR>; > + reset-names = "core_reset"; A "_reset" postfix is redundant. In fact, reset-names shouldn't even be required. > + > sdhc1_opp_table: opp-table { > compatible = "operating-points-v2"; > > @@ -2686,6 +2690,10 @@ > > qcom,dll-config = <0x0007642c>; > > + /* gcc hardware reset entry for SD card */ Please don't add this worthless comment. > + resets = <&gcc GCC_SDCC2_BCR>; > + reset-names = "core_reset"; > + > sdhc2_opp_table: opp-table { > compatible = "operating-points-v2"; >