Quoting Satya Priya Kakitapalli (Temp) (2022-03-30 03:55:03) > > On 3/25/2022 11:32 PM, Stephen Boyd wrote: > > Quoting Satya Priya (2022-03-25 04:58:05) > >> Modify the compatible string as per the pm8008 mfd driver. > >> Add reset-gpios property and make interrupts and interrupt-cells > >> as optional properties, they are not strictly required and may > >> cause yaml compilation errors when not added in the DT files. > > Does it have an interrupt controller inside? If so, the properties > > should be present even if the driver isn't using them. > > > Yes it has an interrupt controller but we are not configuring/using any > interrupts currently in the DT node. So, if we add the properties under > "required" list it throws a make dtbs error. Do you think we can somehow > bypass this error? > Can you fix the existing node to have those properties? > > >> Also, change the node name in example to match with the > >> pm8008_infra DT node. > >> > >> Signed-off-by: Satya Priya <quic_c_skakit@xxxxxxxxxxx> > >> --- > >> Changes in V5: > >> - Remove compatible for regulators node. > >> - Move supply nodes of the regulators to chip level. > >> > >> Changes in V6: > >> - No changes. > >> > >> Changes in V7: > >> - Removed the intermediate regulators node and added ldos > >> directly under mfd node. > >> > >> Changes in V8: > >> - Change the compatible as per driver, remove interrupts from required > >> properties, add reset-gpios and move regulators to separate binding. > >> > >> Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 15 ++++++++++----- > >> 1 file changed, 10 insertions(+), 5 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > >> index ec3138c..12431ea 100644 > >> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > >> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > >> @@ -16,7 +16,7 @@ description: | > >> > >> properties: > >> compatible: > >> - const: qcom,pm8008 > >> + const: qcom,pm8008-infra > > Why is the compatible being replaced with -infra postfix? > > > I've changed the compatible after splitting the probe into two parts > pm8008-infra-probe and pm8008-regulators-probe. Only reason for change > is to make it more readable/understandable. > > Please leave the pm8008 compatible alone.
