On 30/03/2022 18:51, Krzysztof Kozlowski wrote: > On 30/03/2022 17:40, Russell King (Oracle) wrote: >> >>>> + >>>> + - | # Serdes to PHY to SFP connection >>>> + #include <dt-bindings/gpio/gpio.h> >>> >>> Are you sure it works fine? Double define? >> >> Err what? Sorry, I don't understand what you're saying here, please >> explain what the issue is. > > Including the same header twice causes duplicate defines, which should > be visible when testing the binding. I don't see such errors now, so either something changed or I confused with something else. It should work, so let's skip my comment here. Best regards, Krzysztof