On 31/03/2022 04:42, Jacky Huang wrote: > Add the dt-bindings header for Nuvoton MA35D1, that gets shared > between the clock controller and clock references in the dts. > > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx> > --- > .../dt-bindings/clock/nuvoton,ma35d1-clk.h | 262 ++++++++++++++++++ > 1 file changed, 262 insertions(+) > create mode 100644 include/dt-bindings/clock/nuvoton,ma35d1-clk.h > > diff --git a/include/dt-bindings/clock/nuvoton,ma35d1-clk.h b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h > new file mode 100644 > index 000000000000..3634e5edcac5 > --- /dev/null > +++ b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h > @@ -0,0 +1,262 @@ > +/* SPDX-License-Identifier: GPL-2.0+ OR MIT */ Can you make it the same license as bindings? > +/* > + * Copyright (c) 2022 Nuvoton Technology Corporation. > + */ > + > +#ifndef __DT_BINDINGS_MA35D1_CLK_H > +#define __DT_BINDINGS_MA35D1_CLK_H > + > +/* Clock Sources */ > +/* External and Internal oscillator clocks */ > +#define HXT 0 One space after '#define'. Please do not introduce some non-Linux coding style. Best regards, Krzysztof