On Wed, Sep 10, 2014 at 03:18:53PM +0100, Mark Rutland wrote: > On Tue, Sep 09, 2014 at 08:17:17PM +0100, Stefan Wahren wrote: Ugh, this looks like it might be a regulator driver but since the subject line was "ARM: " I deleted it unread - if your changelog looks different to all the other changelogs in the subsystem it probably needs changing. > > >> + sreg = devm_kzalloc(dev, sizeof(*sreg), GFP_KERNEL); > > >> + if (!sreg) > > >> + return -ENOMEM; > > >> + sreg->initdata = initdata; > > >> + sreg->name = of_get_property(np, "regulator-name", NULL); > > > I'm not keen on using of_get_property here. We have no idea if > > > regulator-name is even a string (it should be, but we have no > > > guarantee). > > Better using of_property_read_string? > Yes. That will check the value is NUL-terminated, at least. Or just remove the property entirely... without having seen the bindings if we're specifying the name of the device via the device tree something seems wrong.
Attachment:
signature.asc
Description: Digital signature
