Re: [PATCH v1 2/2] ARM: dts: at91: Describe regulators on at91sam9g20ek

[<Claudiu.Beznea@xxxxxxxxxxxxx>]

On 25.03.2022 17:27, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The at91sam9g20ek has no software controllable regulators, only some fixed
> discrete regulators, but they are there and currently the wm8731 driver
> does try to use them. Show the supplies in the DT and map them for the
> wm8731 so things start up cleanly.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>


> ---
>  arch/arm/boot/dts/at91sam9g20ek_common.dtsi | 36 +++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> index ca03685f0f08..88cf3ab40aa6 100644
> --- a/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20ek_common.dtsi
> @@ -225,6 +225,11 @@ wm8731: wm8731@1b {
>                         clock-names = "mclk";
>                         assigned-clocks = <&pmc PMC_TYPE_SYSTEM 8>;
>                         assigned-clock-rates = <12000000>;
> +
> +                       HPVDD-supply = <&vcc_dac>;
> +                       AVDD-supply = <&vcc_dac>;
> +                       DCVDD-supply = <&reg_3v3>;
> +                       DBVDD-supply = <&reg_3v3>;
>                 };
>         };
> 
> @@ -260,4 +265,35 @@ sound {
>                 atmel,ssc-controller = <&ssc0>;
>                 atmel,audio-codec = <&wm8731>;
>         };
> +
> +       reg_5v: fixedregulator0 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "5V";
> +               regulator-min-microvolt = <5000000>;
> +               regulator-max-microvolt = <5000000>;
> +       };
> +
> +       reg_3v3: fixedregulator1 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "3V3";
> +               vin-supply = <&reg_5v>;
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +
> +       reg_1v: fixedregulator2 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "1V";
> +               vin-supply = <&reg_5v>;
> +               regulator-min-microvolt = <1000000>;
> +               regulator-max-microvolt = <1000000>;
> +       };
> +
> +       vcc_dac: fixedregulator3 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "VCC_DAC";
> +               vin-supply = <&reg_3v3>;
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
>  };
> --
> 2.30.2
>