Re: [PATCH v2 4/5] dt-bindings: phy: uniphier-usb3hs: Fix incorrect clock-names and reset-names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/03/2022 07:20, Kunihiko Hayashi wrote:
> There is no clock-names and reset-names for Pro5 SoC, that should have two
> properties, "gio" and "link" like usb3-ssphy.
> 
> And according to the existing PXs2 devicetree, the clock-names for PXs2 SoC
> should have "link" and "phy", and minItems of clocks should be 2.
> 
> Fixes: 134ab2845acb ("dt-bindings: phy: Convert UniPhier USB3-PHY conroller to json-schema")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
>  .../phy/socionext,uniphier-usb3hs-phy.yaml       | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> index 33946efcac5e..1bbd164f2527 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> @@ -31,12 +31,14 @@ properties:
>      const: 0
>  
>    clocks:
> -    minItems: 1
> +    minItems: 2
>      maxItems: 3
>  
>    clock-names:
>      oneOf:
> -      - const: link          # for PXs2
> +      - items:               # for Pro5
> +          - const: gio
> +          - const: link
>        - items:               # for PXs3 with phy-ext

Similarly to our other discussion, it would be good to convert it to
allOf:if:then: constraining it per compatible. The change itself is ok:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux