On Tue, Mar 29, 2022 at 03:56:09PM -0700, Jakub Kicinski wrote: > On Tue, 29 Mar 2022 10:49:21 +0800 Andy Chiu wrote: > > In some SGMII use cases where both a fixed link external PHY and the > > internal PCS/PMA PHY need to be configured, we should explicitly use a > > phandle "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the > > driver would use "phy-handle" in the DT as the reference to both the > > external and the internal PCS/PMA PHY. > > > > In other cases where the core is connected to a SFP cage, we could still > > point phy-handle to the intenal PCS/PMA PHY, and let the driver connect > > to the SFP module, if exist, via phylink. > > > > Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode) > > Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx> > > Reviewed-by: Greentime Hu <greentime.hu@xxxxxxxxxx> > > Reviewed-by: Robert Hancock <robert.hancock@xxxxxxxxxx> > > I'm not sure if this is a fix or adding support for a new configuration. > Andrew, WDYT? I guess it fails this stable rule: It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or some “oh, that’s not good” issue. In short, something critical. So this probably should be for net-next. Andrew
