On Tue, 29 Mar 2022 10:49:21 +0800 Andy Chiu wrote: > In some SGMII use cases where both a fixed link external PHY and the > internal PCS/PMA PHY need to be configured, we should explicitly use a > phandle "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the > driver would use "phy-handle" in the DT as the reference to both the > external and the internal PCS/PMA PHY. > > In other cases where the core is connected to a SFP cage, we could still > point phy-handle to the intenal PCS/PMA PHY, and let the driver connect > to the SFP module, if exist, via phylink. > > Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode) > Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx> > Reviewed-by: Greentime Hu <greentime.hu@xxxxxxxxxx> > Reviewed-by: Robert Hancock <robert.hancock@xxxxxxxxxx> I'm not sure if this is a fix or adding support for a new configuration. Andrew, WDYT? If it really is a fix and needs to be backported we should take patch 2 out of this series, and post it separately later. Refactoring does not belong in stable trees.
