On 3/25/2022 3:12 PM, Krzysztof Kozlowski wrote:
External email: Use caution opening links or attachments
On 25/03/2022 10:31, Mohan Kumar D wrote:
On 3/25/2022 12:56 PM, Krzysztof Kozlowski wrote:
External email: Use caution opening links or attachments
On 25/03/2022 08:21, Mohan Kumar wrote:
Add iommus property for hda and enable the node for P3737 + P3701
platform.
Signed-off-by: Mohan Kumar <mkumard@xxxxxxxxxx>
---
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 1 +
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index 34d6a01ee1c6..156d5d95fde7 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -1751,6 +1751,7 @@
hda@3510000 {
nvidia,model = "NVIDIA Jetson AGX Orin HDA";
+ status = "okay";
Nodes are enabled by default. Why do you need this?
hda node status is set to "disabled" by default in soc dts file
tegra234.dtsi. The enable is controlled by platform specific dts files.
Oh, surprise... why do you override nodes with full path? This is
error-prone and makes any changes (like node name fixing) difficult.
This should be overridden by label.
I see similar method is followed for earlier boards too for hda and
other nodes. As chance of changing the node name is most unlikely due to
node name is closely tied to HW base address for a given chip. If still
there is a concern will fix with label in next patch.
Best regards,
Krzysztof
