Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759 DCDC converter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 25, 2022 at 04:55:25PM +0100, Krzysztof Kozlowski wrote:

> You mention board, some of_device_get_match_data() so you talk about
> runtime. maybe_unused is not about runtime. It is about build time.

> The code you sent cannot have this structure unused. If you think
> otherwise, please provide argument, but not about runtime (again). You
> can for example build it without OF and see...

If you use of_match_ptr() in the struct device (which is good practice,
didn't check if this driver does it) then that causes the ID table to be
unreferenced as of_match_ptr() compiles to NULL when !OF.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux