Krzysztof Kozlowski <krzk@xxxxxxxxxx> 於 2022年3月25日 週五 下午11:37寫道：
>
> On 25/03/2022 15:59, ChiYuan Huang wrote:
> > Krzysztof Kozlowski <krzk@xxxxxxxxxx> 於 2022年3月25日 週五 下午10:47寫道：
> >>
> >>>>> +
> >>>>> +static const struct of_device_id __maybe_unused rt5759_device_table[] = {
> >>>>
> >>>> I don't think this can be __maybe_unused. It is always referenced via
> >>>> of_match_table, isn't it?
> >>>>
> >>> I think it can declared as '__maybe_unused'.
> >>> If 'of_device_id' is unused, then in probe stage,
> >>> 'of_device_get_match_data' will return NULL.
> >>
> >> But your of_device_id cannot be unused. It is always referenced.
> >>
> > I'm not sure, but your assumption is based on 'CONFIG_OF', right?
> > Only if 'CONFIG_OF' is not defined, then it'll be really unused.
>
> Is it possible to build this driver without CONFIG_OF? Did you try it?
>
No, my development board always use device tree that's defined CONFIG_OF.
But theoretically, you can also check of_device.h, if CONFIG_OF is not
defined, 'of_device_get_match_data' always return NULL.
If so, my usage is still right.
> Best regards,
> Krzysztof
