Hi Maxime, (CC'ing Sakari) Thank you for the patch. On Wed, Mar 23, 2022 at 04:48:23PM +0100, Maxime Ripard wrote: > MIPI-DSI devices, if they are controlled through the bus itself, have to > be described as a child node of the controller they are attached to. > > Thus, there's no requirement on the controller having an OF-Graph output > port to model the data stream: it's assumed that it would go from the > parent to the child. > > However, some bridges controlled through the DSI bus still require an > input OF-Graph port, thus requiring a controller with an OF-Graph output > port. This prevents those bridges from being used with the controllers > that do not have one without any particular reason to. > > Let's drop that requirement. I'm sure this won't come as a surprise, I'm very much opposed to this change, for two reasons. First, ports are part of the hardware, even if they're not connected. It thus simplifies handling in drivers if they're always present. Then, and that's the most important reason, I think it's a mistake not to model the DSI data connection using OF graph unconditionally, even when the DSI sink device is also controlled through the DSI bus (using DCS) and is in that case a child of the DSI source device in the DT hierarchy. The device tree describes a control hierarchy between devices. OF graph overlays on top of that a data transfer graph. The two are different concepts, and the fact that DSI can sometimes be used as a control bus doesn't change the concept. Using OF graph unconditionally to describe the data connections for DSI leads to less variation in the device tree structure, and thus less complexity in the implementation. We're suffering from the fact we haven't made it a requirement in the first place, which can't be fixed due to ABI breakage constraints, but let's not acknowledge it as a good idea. > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > --- > .../devicetree/bindings/display/bridge/chipone,icn6211.yaml | 1 - > .../devicetree/bindings/display/bridge/toshiba,tc358762.yaml | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > index 62c3bd4cb28d..7257fd0ae4da 100644 > --- a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -51,7 +51,6 @@ properties: > Video port for MIPI DPI output (panel or connector). > > required: > - - port@0 > - port@1 > > required: > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml > index 5216c27fc0ad..a412a1da950f 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml > @@ -39,7 +39,6 @@ properties: > Video port for MIPI DPI output (panel or connector). > > required: > - - port@0 > - port@1 > > required: -- Regards, Laurent Pinchart
