On Wed, Mar 23, 2022 at 03:55:50PM +0100, Krzysztof Kozlowski wrote: > On 23/03/2022 15:54, Sakari Ailus wrote: > > Hi Krzysztof, > > > > On Sun, Mar 20, 2022 at 12:56:48PM +0100, Krzysztof Kozlowski wrote: > >> On 18/03/2022 17:51, Sakari Ailus wrote: > >>> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9807-vcm.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Dongwoon Anatech DW9807 voice coil lens driver > >>> + > >>> +maintainers: > >>> + - Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > >>> + > >>> +description: | > >>> + DW9807 is a 10-bit DAC with current sink capability. It is intended for > >>> + controlling voice coil lenses. > >>> + > >>> +properties: > >>> + > >> > >> No blank line. > >> > >>> + compatible: > >>> + const: "dongwoon,dw9807-vcm" > >> > >> No quotes. > > > > Hmm. Strings generally need to be quoted, including the compatible > > strings. > > No, not in dtschema. Almost none of strings are ever quoted. If you need > reference - you example-schema.yaml. Good point. I suppose it's because YAML doesn't require that. I'll drop the quotes in v2. -- Sakari Ailus
