On 23/03/2022 02:54, qinjian[覃健] wrote:
>>> +examples:
>>> + - |
>>> + rstc: reset@9c000054 {
>>> + compatible = "sunplus,sp7021-reset";
>>> + #reset-cells = <1>;
>>> + reg = <0x9c000054 0x28>;
>>
>> I asked you to put the reg after compatible in all DTS code and
>> examples. If you do not agree with a comment, please respond. Ignoring
>> it is not cooperative.
>>
>
> Your reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@xxxxxxxxxxxxx/
>>> + - |
>>> +
>>> + clkc: clock-controller@9c000000 {
>>> + compatible = "sunplus,sp7021-clkc";
>>> + #clock-cells = <1>;
>>> + reg = <0x9c000000 0x280>;
>>
>> In DTS code, please put reg after compatible. In all your examples and
>> DTS patches.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
> I see your review-tag. So, I misunderstand your comments.
> Did you means 'reg' must directly after the 'compatible', like this?
> clkc: clock-controller@9c000000 {
> #clock-cells = <1>;
> compatible = "sunplus,sp7021-clkc";
> reg = <0x9c000000 0x280>;
You moved now compatible so not. First goes compatible, then goes reg.
clock-controller@.... {
compatible = ....;
reg = ...;
here goes the rest;
}
My review tag was conditional because I asked to change the code. Such
review tag should be used by you if you implement what I asked for.
Best regards,
Krzysztof
