On 22/03/2022 07:16, Qin Jian wrote: > Add documentation to describe Sunplus SP7021 reset driver bindings. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx> > --- > .../bindings/reset/sunplus,reset.yaml | 38 ++++++++ > MAINTAINERS | 2 + > include/dt-bindings/reset/sp-sp7021.h | 97 +++++++++++++++++++ > 3 files changed, 137 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/sunplus,reset.yaml > create mode 100644 include/dt-bindings/reset/sp-sp7021.h > > diff --git a/Documentation/devicetree/bindings/reset/sunplus,reset.yaml b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml > new file mode 100644 > index 000000000..c083c821f > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/reset/sunplus,reset.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: Sunplus SoC Reset Controller > + > +maintainers: > + - Qin Jian <qinjian@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: sunplus,sp7021-reset > + > + "#reset-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - "#reset-cells" > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + rstc: reset@9c000054 { > + compatible = "sunplus,sp7021-reset"; > + #reset-cells = <1>; > + reg = <0x9c000054 0x28>; I asked you to put the reg after compatible in all DTS code and examples. If you do not agree with a comment, please respond. Ignoring it is not cooperative. Best regards, Krzysztof
