On 3/22/22 22:57, Laurent Pinchart wrote:
Hi Marek,
On Tue, Mar 22, 2022 at 10:29:56PM +0100, Marek Vasut wrote:
On 3/22/22 20:03, Laurent Pinchart wrote:
From: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
The i.MX8MP Media Block Control (MEDIA BLK_CTRL) is a top-level
peripheral providing access to the NoC and ensuring proper power
sequencing of the peripherals within the MEDIAMIX domain. Add DT
bindings for it.
There is already a driver for block controls of other SoCs in the i.MX8M
family, so these bindings will expand upon that.
Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Reviewed-by: Marek Vasut <marex@xxxxxxx>
[...]
+ power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi",
+ "mipi-csi2", "lcdif2", "isp2", "isp1", "dwe",
+ "mipi-dsi2";
Nit, I cannot say I'm a big fan of calling the power domain "mipi-csi1"
and "mipi-csi2", they are both MIPI CSI2, except there are two of them
CSI2 (#1 and #2).
Maybe mipi-csi2-1 and mipi-csi2-2 would be better ? DTTO for the LCDIF,
where we have lcdifv3 and then mx8mp lcdifv3 and eventually we will have
power domain for lcdif #3 instance in this SoC in hdmimix, so maybe some
lcdif-1/lcdif-2 would be a better name ?
The names come from the reference manual, at least the ones for the
second instance. We have, for instance, SFT_EN_MIPI_CSI_PCLK_RESETN and
SFT_EN_MIPI_CSI2_PCLK_RESETN. Same for DSI and LCDIF, there's DSI and
DSI2, and LCDIF and LCDIF2. The "1" suffix has been added for clarity.
This is a bit bikeshedding territory as I expect the DT node for the
media-blk-ctrl to be written once and never be touched again, so if
anyone feels strongly about using better names (whatever those better
names would be), I don't mind much.
I can submit a v3 once a consensus emerges.
I don't feel strongly about it, I just wanted to point it out.
Let's wait for the others' opinions.
