On 3/22/22 20:03, Laurent Pinchart wrote:
From: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> The i.MX8MP Media Block Control (MEDIA BLK_CTRL) is a top-level peripheral providing access to the NoC and ensuring proper power sequencing of the peripherals within the MEDIAMIX domain. Add DT bindings for it. There is already a driver for block controls of other SoCs in the i.MX8M family, so these bindings will expand upon that. Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Reviewed-by: Marek Vasut <marex@xxxxxxx> [...]
+ power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", + "mipi-csi2", "lcdif2", "isp2", "isp1", "dwe", + "mipi-dsi2";
Nit, I cannot say I'm a big fan of calling the power domain "mipi-csi1" and "mipi-csi2", they are both MIPI CSI2, except there are two of them CSI2 (#1 and #2).
Maybe mipi-csi2-1 and mipi-csi2-2 would be better ? DTTO for the LCDIF, where we have lcdifv3 and then mx8mp lcdifv3 and eventually we will have power domain for lcdif #3 instance in this SoC in hdmimix, so maybe some lcdif-1/lcdif-2 would be a better name ?
[...]
