On Fri, 2022-03-18 at 13:00 +0200, Vladimir Oltean wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Mar 18, 2022 at 02:25:38PM +0530, Prasanna Vengateshan wrote: > > Added support for port_mirror_add() and port_mirror_del operations > > > > Sniffing is limited to one port & alert the user if any new > > sniffing port is selected > > > > Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@xxxxxxxxxxxxx> > > Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx> > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > --- > > drivers/net/dsa/microchip/lan937x_main.c | 84 ++++++++++++++++++++++++ > > 1 file changed, 84 insertions(+) > > > > diff --git a/drivers/net/dsa/microchip/lan937x_main.c > > b/drivers/net/dsa/microchip/lan937x_main.c > > index c54aba6a05b5..5a57a2ce8992 100644 > > --- a/drivers/net/dsa/microchip/lan937x_main.c > > +++ b/drivers/net/dsa/microchip/lan937x_main.c > > @@ -98,6 +98,88 @@ static void lan937x_port_stp_state_set(struct dsa_switch > > *ds, int port, > > ksz_update_port_member(dev, port); > > } > > > > +static int lan937x_port_mirror_add(struct dsa_switch *ds, int port, > > + struct dsa_mall_mirror_tc_entry *mirror, > > + bool ingress) > > This function gained a new extack argument yesterday => your patch > doesn't compile. Maybe you could even use the extack to propagate the > "existing sniffer port" error. > > Sure, will use the extack for existing errors. Prasanna V
