On Sun, 2022-03-20 at 01:49 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > +examples: > > > + port@6 { > > + reg = <6>; > > + label = "lan5"; > > + phy-mode = "internal"; > > + phy-handle = <&t1phy4>; > > + }; > > + port@7 { > > + reg = <7>; > > + label = "lan3"; > > + phy-mode = "internal"; > > + phy-handle = <&t1phy5>; > > + }; > > + }; > > + > > + mdio { > > .. > > > + t1phy4: ethernet-phy@6{ > > + reg = <0x6>; > > + }; > > + t1phy5: ethernet-phy@7{ > > + reg = <0x7>; > > + }; > > I know it is only an example, but the numbering is a little odd here. > > Port 6, which is named lan5 using t1phy4 at address 6? > > I would be more likely to use t1phy6 instead of t1phy4. And t1phy7 > instead of t1phy5. > > Andrew Sure, will change it in the next rev as above, Labels are just named to understand front panel naming. Prasanna V