On Fri, Mar 04, 2022 at 03:04:17PM +0530, Divya Koppera wrote: > Supports configuring latency values and also adds > check for phy timestamping feature. > > Signed-off-by: Divya Koppera<Divya.Koppera@xxxxxxxxxxxxx> should be a space here: ^ > --- > .../devicetree/bindings/net/micrel.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Please convert this to DT schema. > > diff --git a/Documentation/devicetree/bindings/net/micrel.txt b/Documentation/devicetree/bindings/net/micrel.txt > index 8d157f0295a5..c5ab62c39133 100644 > --- a/Documentation/devicetree/bindings/net/micrel.txt > +++ b/Documentation/devicetree/bindings/net/micrel.txt > @@ -45,3 +45,20 @@ Optional properties: > > In fiber mode, auto-negotiation is disabled and the PHY can only work in > 100base-fx (full and half duplex) modes. > + > + - lan8814,ignore-ts: If present the PHY will not support timestamping. 'lan8814' is not a vendor and the format for properties is <vendor>,<propname>. Is this configuration or lack of h/w feature? IOW, instead of 'will not', 'does not' or 'timestamping is disabled.'. As configuration, that seems like common property. For (lack of) h/w features, that should be implied by the compatible or VID/PID. > + This option acts as check whether Timestamping is supported by > + hardware or not. LAN8814 phy support hardware tmestamping. > + > + - lan8814,latency_rx_10: Configures Latency value of phy in ingress at 10 Mbps. s/_/-/ What are the units here? Is this a common feature of PHYs? > + > + - lan8814,latency_tx_10: Configures Latency value of phy in egress at 10 Mbps. > + > + - lan8814,latency_rx_100: Configures Latency value of phy in ingress at 100 Mbps. > + > + - lan8814,latency_tx_100: Configures Latency value of phy in egress at 100 Mbps. > + > + - lan8814,latency_rx_1000: Configures Latency value of phy in ingress at 1000 Mbps. > + > + - lan8814,latency_tx_1000: Configures Latency value of phy in egress at 1000 Mbps. > -- > 2.17.1 > >
