On Wed, 2 Mar 2022 13:48:01 -0800 Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > I'm ok with this patch; a quick grep though shows a few more open > coded instances of pkg-config. Should we fix those up, too? i.e. > > certs/Makefile:92:HOSTCFLAGS_extract-cert.o = $(shell pkg-config > --cflags libcrypto 2> /dev/null) > certs/Makefile:93:HOSTLDLIBS_extract-cert = $(shell pkg-config --libs > libcrypto 2> /dev/null || echo -lcrypto) > scripts/kconfig/gconf-cfg.sh For this patch set, the above is probably good enough to do (and test with a make allmodconfig). > tools/perf/Makefile.perf > tools/ in general I would hold off on doing tools for a separate patch. With the exception of objtool most of tools is not needed for the build process. -- Steve