On Wed, 2 Mar 2022 08:18:15 -0600
Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> On Tue, Mar 1, 2022 at 5:07 PM Chun-Tse Shao <ctshao@xxxxxxxxxx> wrote:
> >
> > In some parts, pkg-config does not use appropriate $BUILDROOT prefix.
>
> The kernel tree knows nothing about buildroot. Please reword this in a
> more generic way that you need to override the host pkg-config.
I don't even know what $BUILDROOT is ;-)
But I do know that it's good practice to allow pkg-config to be overridden.
I have several user space tools that needed it done to allow distros to
install them properly.
Would you be OK with a description like:
Allow kernel installation packaging to override pkg-config.
?
>
> > The patch adds HOSTPKG_CONFIG prefix for pkg-config to fix the issue.
A couple of things. It is consider poor form to reference "the patch".
Another thing is that this is not a prefix for pkg-config, it is overriding
what pkg-config is used during the build process.
Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override
what pkg-config and parameters are used.
Something like that.
-- Steve
> >
> > Signed-off-by: Chun-Tse Shao <ctshao@xxxxxxxxxx>
