Re: [PATCH 2/3 v4] dts: rockchip: Add #clock-cells value for rk805

[Robin Murphy <robin.murphy@xxxxxxx>]

On 2022-03-02 23:26, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@xxxxxxxxxxx>
>
> Based on a brief discussion on the mailing list it was determined that
> clock-cells should be a required parameter in the event that a consumer
> of the clock gets added in an overlay.

Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/rv1108-elgin-r1.dts      | 1 +
>   arch/arm/boot/dts/rv1108-evb.dts           | 1 +
>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 +
>   3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> index f62c9f7af79d..0c99a5934ebf 100644
> --- a/arch/arm/boot/dts/rv1108-elgin-r1.dts
> +++ b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> @@ -72,6 +72,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index fe5fc9bf75c9..46cad7cb94bf 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -85,6 +85,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> index de2d3e88e27f..40bf808642b9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> @@ -160,6 +160,7 @@ pmic@18 {
>   		pinctrl-0 = <&pmic_int_l>;
>   		rockchip,system-power-controller;
>   		wakeup-source;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;