On 01/03/2022 03:08, qinjian[覃健] wrote: >>>>>> This binding looks incomplete. >>>>> >>>>> Sunplus SP7021 is an ARM Cortex A7 based SoC. >>>>> The patch is for SP7021 SoC and SP7021 based boards. >>>>> Sorry, I don't understand your questions. >>>>> Could you explain more? >>>> >>>> You have there only one compatible but if I would expect at least two. >>>> One for SoC and one for board. Something like this: >>>> Documentation/devicetree/bindings/arm/rda.yaml >>>> but in your case enum would have only one entry. >>> >>> Currently, we only support one board. Maybe will support more boards in future. >> >> This is not the answer for my questions. I said I expect two compatibles: >> 1. One for SoC, >> 2. One for board. >> >> And you respond "we have only one board". >> >> Where is the SoC compatible? >> > > Got it, thanks for your explanation. > > I'll add the SoC compatible(sunplus,sp7021) in next patch. > > compatible: > items: > - enum: > - sunplus,sp7021-achip > - const: sunplus,sp7021 Yes, this looks correct (assuming "sp7021-achip" is the name for this board. Best regards, Krzysztof
