On 21/02/2022 04:29, Qin Jian wrote: > This introduces bindings for boards based Sunplus SP7021 SoC. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx> > --- > .../bindings/arm/sunplus,sp7021.yaml | 27 +++++++++++++++++++ > MAINTAINERS | 7 +++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml > > diff --git a/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml b/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml > new file mode 100644 > index 000000000..5b9985b73 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/sunplus,sp7021.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SP7021 Boards Device Tree Bindings > + > +maintainers: > + - qinjian <qinjian@xxxxxxxxxxx> > + > +description: | > + ARM platforms using Sunplus SP7021, an ARM Cortex A7 (4-cores) based SoC. > + Wiki: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - items: > + - const: sunplus,sp7021-achip > + You did not publish DTS so bigger picture and context are missing here. Is it a SoC compatible? A board compatible? Why only one? Against what does it validate? This binding looks incomplete. Best regards, Krzysztof
