Hi Marek, Thank you for the patch. On Mon, Feb 28, 2022 at 01:45:57AM +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it > has a completely scrambled register layout compared to all previous LCDIF > variants. The new LCDIFv3 also supports 36bit address space. However, > except for the complete bit reshuffling, this is still LCDIF and it still > works like one. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: Peng Fan <peng.fan@xxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Robby Cai <robby.cai@xxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Stefan Agner <stefan@xxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 900a56cae80e6..9831ab53a053d 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -28,6 +28,7 @@ properties: > - fsl,imx7d-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif As the hardware isn't backward-compatible with any other version, I think the new compatible string should go in the previous enum block, not in this one. We don't want the imx6sx fallback. > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif > -- Regards, Laurent Pinchart
