Hi Peter, Lots of USB series all of a sudden. Combine possible? On 2/25/22 15:54, Peter Geis wrote: > The rk3568 dwc3 controllers are backwards compatible with the rk3399. > Add the device tree description for it. > > Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx> > --- > Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml b/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml > index 04077f2d7faf..e3044e81cc72 100644 > --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml > @@ -30,6 +30,7 @@ select: > enum: > - rockchip,rk3328-dwc3 > - rockchip,rk3399-dwc3 > + - rockchip,rk3568-dwc3 > required: > - compatible > > @@ -39,6 +40,7 @@ properties: > - enum: > - rockchip,rk3328-dwc3 > - rockchip,rk3399-dwc3 > + - rockchip,rk3568-dwc3 > - const: snps,dwc3 > > reg: > @@ -75,7 +77,10 @@ properties: > maxItems: 1 > he > reset-names: > - const: usb3-otg > + items: > + - enum: > + - usb3-otg > + - usb3-host The use of reset-names is "sort of" only related to the rk3399 legacy node. Still using this sub node DT to not to break older existing boot loaders. https://github.com/torvalds/linux/search?q=usb3-otg It's only mentioned as comment in dwc3-of-simple.c but not used: simple->resets = of_reset_control_array_get(np, false, true, true); core.c uses something similar. dwc->reset = devm_reset_control_array_get_optional_shared(dev); if (IS_ERR(dwc->reset)) return PTR_ERR(dwc->reset); Up to the maintainers, but I wouldn't add another variant/name for the same thing as it also optional(= not required) and no longer needed. Johan === Maybe drop PCLK_PIPE as well to reduce notifications. See example: https://lore.kernel.org/linux-rockchip/20220225131602.2283499-4-michael.riesch@xxxxxxxxxxxxxx/T/#u > > unevaluatedProperties: false >
