On 24/02/2022 at 15:55, Michael Walle wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Hi,
Am 2022-02-24 15:51, schrieb Nicolas Ferre:
+/ {
+ model = "Microchip LAN966 family SoC";
+ compatible = "microchip,lan966";
As mentioned earlier, this isn't a documented compatible string. So,
I guess without overwriting this in the board dts it will throw an
error with the dt schema validator. OTOH, there are many dtsi files
in arch/arm/boot/dts/ doing this. I don't know what is correct here.
I see it documented here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/atmel-at91.yaml#n165
Isn't it what is expected?
That only documents
compatible = "microchip,lan9662-pcb8291", "microchip,lan9662",
"microchip,lan966";
But not the one above.
Oh, you mean the "microchip,lan966" string alone in the compatibility
string and not with the other ones before it...
I didn't know it could be different in yaml syntax. Thanks for
highlighting that.
Best regards,
Nicolas
Everthing else looks good.
Thanks a lot for your reviews.
Reviewed-by: Michael Walle <michael@xxxxxxxx>
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
I'm queuing it to at91-dt branch for reaching arm-soc in 5.18 merge
window.
Nice, then I'm good to go for my patches on top of this :)
-michael
--
Nicolas Ferre
