On 23/02/2022 14:56, 隋景峰 wrote: > > > > > -----Original Messages----- > > From: "Rob Herring" <robh@xxxxxxxxxx> > > Sent Time: 2022-02-23 07:02:34 (Wednesday) > > To: "Sui Jingfeng" <15330273260@xxxxxx> > > Cc: "Maxime Ripard" <mripard@xxxxxxxxxx>, "Thomas Zimmermann" <tzimmermann@xxxxxxx>, "Roland Scheidegger" <sroland@xxxxxxxxxx>, "Zack Rusin" <zackr@xxxxxxxxxx>, "Christian Gmeiner" <christian.gmeiner@xxxxxxxxx>, "David Airlie" <airlied@xxxxxxxx>, "Daniel Vetter" <daniel@xxxxxxxx>, "Thomas Bogendoerfer" <tsbogend@xxxxxxxxxxxxxxxx>, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk@xxxxxxxxxx>, "Andrey Zhizhikin" <andrey.zhizhikin@xxxxxxxxxxxxxxxxxxxx>, "Sam Ravnborg" <sam@xxxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, "Jiaxun Yang" <jiaxun.yang@xxxxxxxxxxx>, "Lucas Stach" <l.stach@xxxxxxxxxxxxxx>, "Maarten Lankhorst" <maarten.lankhorst@xxxxxxxxxxxxxxx>, "Ilia Mirkin" <imirkin@xxxxxxxxxxxx>, "Qing Zhang" <zhangqing@xxxxxxxxxxx>, suijingfeng <suijingfeng@xxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH v10 2/4] Documentation/dt: Add descriptions for loongson display controller > > > > On Sun, Feb 20, 2022 at 10:55:52PM +0800, Sui Jingfeng wrote: > > > From: suijingfeng <suijingfeng@xxxxxxxxxxx> > > > > Follow the conventions of the subsystem for patch subjects. It should be > > evident with 'git log --oneline Documentation/devicetree/bindings/display'. > > > > Something like this: > > > > dt-bindings: display: Add Loongson display controller > > > > Hi, > > We are not a platform device driver, there is no > of_device_id defined in my driver. In other word, > my driver will not bind against devices whose compatible > is "loongson,ls7a1000-dc". We just parse the device tree > actively, find necessary information of interest. > In this case, can I use the word "dt-bindings" in the commit title? This is a patch for specific subsystem, so as Rob said, it should follow subsystem conventions. The patch itself is a dt-bindings patch, so there is nothing here special which would encourage for any exception. > > I want to follow the conventions, but get some push back, > Krzysztof say that he can not see any bindings, these are not bindings. I said in comment to your patch with DTS, which you called bindings, that there are no bindings at all in it. Because in your patch with DTS you did not include bindings, but you called it bindings. Here, this is a patch with bindings, so your comment "these are not bindings" is not true. </suijingfeng@xxxxxxxxxxx></suijingfeng@xxxxxxxxxxx></zhangqing@xxxxxxxxxxx></imirkin@xxxxxxxxxxxx></maarten.lankhorst@xxxxxxxxxxxxxxx></l.stach@xxxxxxxxxxxxxx></jiaxun.yang@xxxxxxxxxxx></davem@xxxxxxxxxxxxx></sam@xxxxxxxxxxxx></andrey.zhizhikin@xxxxxxxxxxxxxxxxxxxx></krzk@xxxxxxxxxx></dan.carpenter@xxxxxxxxxx></tsbogend@xxxxxxxxxxxxxxxx></daniel@xxxxxxxx></airlied@xxxxxxxx></christian.gmeiner@xxxxxxxxx></zackr@xxxxxxxxxx></sroland@xxxxxxxxxx></tzimmermann@xxxxxxx></mripard@xxxxxxxxxx></robh@xxxxxxxxxx> This link does not work... > This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. Such automatic footers do not help. Could you work on a way to avoid them? Best regards, Krzysztof
