On Mon, Feb 21, 2022 at 06:20:00AM +0000, Tao Wang (Consultant) (QUIC) wrote: > Hi, > > > > Regarding on board hub driver, > > [1]https://lore.kernel.org/linux-usb/20220119124327.v20.3.I7c9a1f1d6ced > 41dd8310e8a03da666a32364e790@changeid/#R > > > I have one comment below, > > > +static const struct usb_device_id onboard_hub_id_table[] = { > > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 > */ > > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 > */ > > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 > */ > > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 > */ > > + {} > > +}; > > +MODULE_DEVICE_TABLE(usb, onboard_hub_id_table); > > > Can we support read VID/PID from device tree which provide platfrom > device info? As far as I understand the kernel exclusively uses the VID/PID reported by the USB device, the compatible string in the device tree is purely informational (though this driver uses it for the platform device).