On Fri, 2022-02-11 at 19:56 -0800, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 2/9/2022 3:58 AM, Prasanna Vengateshan wrote: > > On Mon, 2022-02-07 at 18:53 -0800, Florian Fainelli wrote: > > > > > > > + rx-internal-delay-ps: > > > > + $ref: "#/$defs/internal-delay-ps" > > > > + tx-internal-delay-ps: > > > > + $ref: "#/$defs/internal-delay-ps" > > > > > > Likewise, this should actually be changed in ethernet-controller.yaml > > > > There is *-internal-delay-ps property defined for mac in ethernet- > > controller.yaml. Should that be changed like above? > > It seems to me that these properties override whatever 'phy-mode' > property is defined, but in premise you are right that this is largely > applicable to RGMII only. I seem to recall that the QCA8K driver had > some sort of similar delay being applied even in SGMII mode but I am not > sure if we got to the bottom of this. > > Please make sure that this does not create regressions for other DTS in > the tree before going with that change in ethernet-controller.yaml. Okay, Can these be submitted as a seperate patch? Prasanna V
