Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tue, Feb 8, 2022 at 3:43 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Don't we want to introduce a family-specific compatible value for
> > R-Car Gen4? At least the SCSS seems to be a new R-Car Gen4 feature
> > common to R-Car S4 and R-Car V3U (yes, the latter is advertised as
> > the first member of the R-Car Gen4 family, so I intend to move it
> > over to renesas,rcar-gen4-* where it makes sense).
>
> Yeah, sure we want the family compatible. But for now it can point to
> I2C_RCAR_GEN3, so the patch can stay as is. That is what I was wondering
> about why a v2 was needed. If we add SCSS, we can update the family
> compatible data for Gen4 to I2C_RCAR_GEN4. Unless I miss something.

Ah, there's the source of the confusion! ;-)

There's a need for a v2 because the patch description says R-Car S4
supports FM+, which is false.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux