On Mon, Feb 07, 2022 at 10:20:14PM +0100, Pawel Dembicki wrote:
> Ctera C200 V1 is kirkwood-based 2-Bay NAS.
>
> Hardware:
> - SoC: Marvell 88F6281-A1 ARMv5TE Processor 1.2GHz
> - Ram: 512MB (4x Nanya NT5TU128M8GE-AC)
> - NAND Flash: 256MB (Samsung 216 K9F2G08U0C)
> - Lan: 1x GBE (Marvell 88E1116R-NNC1)
> - Storage: 2x SATA HDD 3.5" Slot
> - USB: 2x USB 2.0 port
> - Console: Internal J3 connector (1: Vcc, 2: Rx, 3: Tx, 4: GND)
> - LEDs: 13x GPIO controlled
> - Buttons: 2x GPIO controlled
>
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>
Hi Pawel
It is a good idea to Cc: the mvebu maintainers, since kirkwood is part
of that.
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&pmx_leds>;
> + pinctrl-names = "default";
> +
> +
Please avoid 2 blank lines. This happens a few times in this file.
> +&pciec {
> + status = "okay";
> +};
It would be nice to have a comment about what is on the PCIe bus. Or
is it just a socket?
> +
> +&pcie0 {
> + status = "okay";
> +};
> +
> +&pinctrl {
> + /* buzzer gpios are connected to two pins of buzzer
> + * leave it as is due lack of proper driver
> + */
> + pmx_buzzer: pmx-buzzer {
> + marvell,pins = "mpp12", "mpp13";
> + marvell,function = "gpio";
> + };
Is it possible to use "gpio-beeper"?
beeper: beeper {
/* 4KHz Piezoelectric buzzer */
compatible = "gpio-beeper";
pinctrl-0 = <&pmx_beeper>;
pinctrl-names = "default";
gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
};
Andrew
