> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: 07 February 2022 20:36 > To: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx> > Cc: thierry.reding@xxxxxxxxx; Jonathan Hunter <jonathanh@xxxxxxxxxx>; > linux-spi@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Sowjanya > Komatineni <skomatineni@xxxxxxxxxx>; Laxman Dewangan > <ldewangan@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > p.zabel@xxxxxxxxxxxxxx > Subject: Re: [PATCH 6/6] spi: tegra210-quad: combined sequence mode > > On Mon, Feb 07, 2022 at 02:54:00PM +0000, Krishna Yarlagadda wrote: > > > > > + if (cdata->is_cmb_xfer && transfer_count == 3) > > > > + ret = tegra_qspi_combined_seq_xfer(tqspi, msg); > > > > + else > > > > + ret = tegra_qspi_non_combined_seq_xfer(tqspi, msg); > > > > This check needs to be more specific. But like I said in reply to > > > the binding patch I don't see why we can't just pattern match on the > > > data without requiring a property here, we'd need to check that the > > > message is suitable no matter what. > > > There is no real-world use case we encountered so far preventing us stick > to pattern. > > But this was to avoid any corner case where there could be 3 different > transfers sent in single msg. > > So you'll remove the property and just pattern match on the message? Yes. I will send out V2 without property. > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to. Sorry. Fixed mail client now.
