On Fri, Feb 04, 2022 at 03:59:36PM +0530, Krishna Yarlagadda wrote:
> + /* Process individual transfer list */
> + list_for_each_entry(xfer, &msg->transfers, transfer_list) {
> + if (transfer_phase == CMD_TRANSFER) {
> + } else if (transfer_phase == ADDR_TRANSFER) {
> + } else {
Looks like you're writing a switch statement here...
> + /* X1 SDR mode */
> + cmd_config = tegra_qspi_cmd_config(false, 0,
> + xfer->len);
> + cmd_value = *((const u8 *)(xfer->tx_buf));
> +
> + len = xfer->len;
> + /* X1 SDR mode */
> + addr_config = tegra_qspi_addr_config(false, 0,
> + xfer->len);
> + address_value = *((const u32 *)(xfer->tx_buf));
> + /* Program Command, Address value in register */
> + tegra_qspi_writel(tqspi, cmd_value, QSPI_CMB_SEQ_CMD);
> + tegra_qspi_writel(tqspi, address_value,
> + QSPI_CMB_SEQ_ADDR);
> + /* Program Command and Address config in register */
> + tegra_qspi_writel(tqspi, cmd_config,
> + QSPI_CMB_SEQ_CMD_CFG);
> + tegra_qspi_writel(tqspi, addr_config,
> + QSPI_CMB_SEQ_ADDR_CFG);
It looks like the command and address have to be specific lengths? If
that's the case then
> + if (cdata->is_cmb_xfer && transfer_count == 3)
> + ret = tegra_qspi_combined_seq_xfer(tqspi, msg);
> + else
> + ret = tegra_qspi_non_combined_seq_xfer(tqspi, msg);
This check needs to be more specific. But like I said in reply to the
binding patch I don't see why we can't just pattern match on the data
without requiring a property here, we'd need to check that the message
is suitable no matter what.
Attachment:
signature.asc
Description: PGP signature
