On Sun, Jan 30, 2022 at 12:43:46AM +0800, Joseph CHAMG wrote: > Add davicom dm9051 spi ethernet driver, The driver work for the > device platform which has the spi master > > Signed-off-by: Joseph CHAMG <josright123@xxxxxxxxx> > --- > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Andrew Lunn <andrew@xxxxxxx> > Cc: Leon Romanovsky <leon@xxxxxxxxxx> > Cc: andy Shevchenko <andy.shevchenko@xxxxxxxxx> <...> > +static int dm9051_probe(struct spi_device *spi) > +{ > + struct device *dev = &spi->dev; > + struct net_device *ndev; > + struct board_info *db; > + int ret = 0; <...> > + kthread_init_worker(&db->kw); > + kthread_init_work(&db->kw_rxctrl, dm9051_rxctl_delay); > + kthread_init_work(&db->kw_tx, dm9051_tx_delay); > + > + db->kwr_task_kw = kthread_run(kthread_worker_fn, &db->kw, "dm9051"); It is very unlikely that simple driver like this will need kthreads, does it really need? Thanks