On Fri, Aug 29, 2014 at 10:03:27PM +0200, Geert Uytterhoeven wrote: > Hi Uli, > > On Fri, Aug 29, 2014 at 8:16 PM, Ulrich Hecht > <ulrich.hecht+renesas@xxxxxxxxx> wrote: > > These are the dtsi files for r8a7778 and r8a7779 sorted according to what I > > imagine to be accepted standards now: sort by address, "compatible" goes > > first, #include directives before anything else. The sorting was done using > > a little script I wrote (https://github.com/uli/dtssort). > > Nice! (but soon thereafter I got sidetracked by decomp ;-) > > > I chose these two files because the required changes are relatively small. > > Doing this for r8a779x yields a gargantuan and entirely unreadable patch due > > to the random shifting about of large blocks of code. If anybody knows a > > tool that makes such things somewhat manageable to review, please speak up. > > You more or less gave a solution at the top of your email: split it in multiple > patches: one to sort the includes, one to sort the properties inside the nodes, > and one single patch for each node you move. > Yes, too many patches, but good for the patch statistics ;-) FWIW, I would rather many small patches than one gargatuan one. > Another approach could be to start considering SoCs as built from multiple > hardware blocks, not only at the hardware/software level, but also at the DTS > level. I.e. use macros to instantiate nodes. This makes it easier to avoid > stupid typos in e.g. the 5th i2c node. In addition, many SoCs are similar, and > only differ in a few nodes. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
