Re: [PATCH] arm64: dts: qcom: sm8150: Add ufs power-domain entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At 20.01.2022 11:28, Bhupesh Sharma wrote:
Add power-domain entries for UFS controller & phy nodes
in sm8150 dts.

...
+			power-domains = <&gcc UFS_PHY_GDSC>;
  			resets = <&gcc GCC_UFS_PHY_BCR>;
  			reset-names = "rst";
...
+			power-domains = <&gcc UFS_CARD_GDSC>,
+					<&gcc UFS_PHY_GDSC>;
+			power-domain-names = "ufs_card_gdsc", "ufs_phy_gdsc";

Strange, but I don't see neither UFS_PHY_GDSC nor UFS_CARD_GDSC in gcc-sm8150.c [1] (and accordingly not in include/dt-bindings/clock/qcom,gcc-sm8150.h), but they are present in corresponding files for sm8250 [2].

By quick look at downstream sm8150-gdsc.dtsi addresses seem to be similar to one used on sm8250, so I'm guessing gcc-sm8150 has to be fixed first for this patch to work?

[1] https://elixir.bootlin.com/linux/v5.17-rc1/source/drivers/clk/qcom/gcc-sm8150.c#L3716 [2] https://elixir.bootlin.com/linux/v5.17-rc1/source/drivers/clk/qcom/gcc-sm8250.c#L3522

--
Regards
Alexey Minnekhanov
postmarketOS developer
https://www.postmarketos.org



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux