The 01/27/2022 07:28, Richard Cochran wrote: > > On Thu, Jan 27, 2022 at 11:23:29AM +0100, Horatiu Vultur wrote: > > > +static int lan966x_ptp_phc_init(struct lan966x *lan966x, > > + int index, > > + struct ptp_clock_info *clock_info) > > +{ > > + struct lan966x_phc *phc = &lan966x->phc[index]; > > + > > + phc->info = *clock_info; > > + phc->clock = ptp_clock_register(&phc->info, lan966x->dev); > > + if (IS_ERR(phc->clock)) > > + return PTR_ERR(phc->clock); > > + > > + phc->index = index; > > + phc->lan966x = lan966x; > > + > > + /* PTP Rx stamping is always enabled. */ > > + phc->hwtstamp_config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT; > > Not true -- you allow it to be disabled in the next patch! Actually the other patch is wrong. The HW will timestamp all the frames. I will update the other patch in the next version. > > Thanks, > Richard > > > > + > > + return 0; > > +} -- /Horatiu