Hi Bjorn, On Fri, 17 Dec 2021 at 18:32, Loic Poulain <loic.poulain@xxxxxxxxxx> wrote: > > Add support for the display clock controller found in QCM2290 > based devices. This clock controller feeds the Multimedia Display > SubSystem (MDSS). > > It's a porting of dispcc-scuba GPL-2.0 driver from CAF msm-4.19 kernel: > https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/clk/qcom/dispcc-scuba.c?h=LE.UM.4.4.1.r3 > > Global clock name references (parent_names) have been replaced by > parent_data and parent_hws. > > Clocks marked enable_safe_config have their clk_rcg2_ops moved to > clk_rcg2_shared_ops. > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> Any other comments on this series? Regards, Loic > --- > v2: Added missing dispcc-qcm2290.h header file > v3: - Moved dt-bindings header into dt bindings commit > - clk_rcg2_ops to clk_rcg2_shared_ops for enable_safe_config > marked clocks. > v4: - Removed useless NOCACHE clk flags > - Added explicit comment for OPS_PARENT_ENABLE flag > - Removed useless headers (clk.h, reset.h) > - spark_vco tab as const > - removed global .name reference for sleep_clk > - removed dispcc_xo_clk as it is always on (enabled in probe) > - removed dev_info message on probe success > - Kconfig: Select QCM_GCC_2290 for builtin