Hi Mati, Looks like my last reply [1] raced with this posting. [...] > +Optional properties: > +- trickle : Used Trickle Charger configuration, > + corresponding to 4 lowest bits in trickle charger register. > + Following values are specified: > + 0x5 => No diode, 250 ohm > + 0x9 => Diode, 250 ohm > + 0x6 => No diode, 2k ohm > + 0xa => Diode, 2k ohm > + 0x7 => No diode, 4k ohm > + 0xb => Diode, 4k ohm Optional? For an optional property, please describe when said property should be present, and what the absence implies. Usually something like "should be present if $foo is not implemented in $such_way", so it's obvious what the behaviour should be either way. I still think this should be two proeprties and that the driver should handle that as appropriate, as I mentioned in my last reply [1]. Mark. [1] http://lkml.kernel.org/r/20140829104001.GB19424@leverpostej -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html