Hi Andy Shevchenko : Thanks for your comment, I have some questions as below. > > + if (xfer->tx_buf) > > + dma_unmap_single(dev, xfer->tx_dma, xfer->len, DMA_TO_DEVICE); > > + if (xfer->rx_buf) > > + dma_unmap_single(dev, xfer->rx_dma, xfer->len, > > + DMA_FROM_DEVICE); > > Why can't you use SPI core DMA mapping code? I didn't find the SPI core DMA mapping code for single maping. The method currently used is the general DMA single-map code usage method. > > > + device_set_node(&ctlr->dev, pdev->dev.fwnode); > > Use dev_fwnode() in the second argument. > You mean as below ? device_set_node(&ctlr->dev, dev_fwnode(dev)); Best Regards, Li-hao Kuo
