Re: [PATCH v8 5/7] arm64: dts: renesas: eagle: Enable MAX9286

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacopo, Kieran,

On Thu, Dec 16, 2021 at 5:34 PM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
> From: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>
> Enable the MAX9286 GMSL deserializer on the Eagle-V3M board.
>
> Connected cameras should be defined in a device-tree overlay or included
> after these definitions.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -6,6 +6,8 @@
>   * Copyright (C) 2017 Cogent Embedded, Inc.
>   */
>
> +#include <dt-bindings/gpio/gpio.h>

Already included below.

> +
>  /dts-v1/;
>  #include "r8a77970.dtsi"
>  #include <dt-bindings/gpio/gpio.h>

> @@ -278,6 +285,103 @@ &rwdt {
>         status = "okay";
>  };
>
> +&csi40 {

Moving up...

> +       status = "okay";
> +
> +       ports {
> +               port@0 {
> +                       csi40_in: endpoint {
> +                               clock-lanes = <0>;
> +                               data-lanes = <1 2 3 4>;
> +                               remote-endpoint = <&max9286_out0>;
> +                       };
> +               };
> +       };
> +};
> +
> +&i2c3 {

Moving up...

> +       pinctrl-0 = <&i2c3_pins>;
> +       pinctrl-names = "default";
> +
> +       status = "okay";
> +       clock-frequency = <400000>;
> +
> +       gmsl0: gmsl-deserializer@48 {
> +               compatible = "maxim,max9286";
> +               reg = <0x48>;
> +
> +               maxim,gpio-poc = <0 GPIO_ACTIVE_LOW>;
> +               enable-gpios = <&io_expander 0 GPIO_ACTIVE_HIGH>;
> +
> +               ports {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       port@0 {
> +                               reg = <0>;
> +                       };
> +
> +                       port@1 {
> +                               reg = <1>;
> +                       };
> +
> +                       port@2 {
> +                               reg = <2>;
> +                       };
> +
> +                       port@3 {
> +                               reg = <3>;
> +                       };
> +
> +                       port@4 {
> +                               reg = <4>;
> +                               max9286_out0: endpoint {
> +                                       clock-lanes = <0>;
> +                                       data-lanes = <1 2 3 4>;
> +                                       remote-endpoint = <&csi40_in>;
> +                               };
> +                       };
> +               };
> +
> +               i2c-mux {

Should we move i2c-mux before ports, too?

> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       i2c@0 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               reg = <0>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       i2c@1 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               reg = <1>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       i2c@2 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               reg = <2>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       i2c@3 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               reg = <3>;
> +
> +                               status = "disabled";
> +                       };
> +               };
> +       };
> +};
> +

I can fix all of these while applying.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux