Hi Shunzhou, On 18/01/2022 03:26, shunzhou.jiang@xxxxxxxxxxx wrote: > Dears Neil & Martin: > Sorry for my late reply > S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash > S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb > S4_ETH: for ethernet online wakeup, and if power down, status also not right >>> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), >>> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), >>> + SEC_PD(S4_GE2D, 0), >>> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), Thanks for clarifications, can you resend the patchset with those infos in comments like it was done for A1 ? Thanks, Neil > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > Shunzhou Jiang > SW Department > > > *From:* Neil Armstrong <mailto:narmstrong@xxxxxxxxxxxx> > *Date:* 2022-01-12 16:36 > *To:* Martin Blumenstingl <mailto:martin.blumenstingl@xxxxxxxxxxxxxx>; Shunzhou.Jiang <mailto:shunzhou.jiang@xxxxxxxxxxx> > *CC:* devicetree <mailto:devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel <mailto:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-amlogic <mailto:linux-amlogic@xxxxxxxxxxxxxxxxxxx>; linux-kernel <mailto:linux-kernel@xxxxxxxxxxxxxxx>; khilman <mailto:khilman@xxxxxxxxxxxx>; jbrunet <mailto:jbrunet@xxxxxxxxxxxx> > *Subject:* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller > [ EXTERNAL EMAIL ] > > Hi Shunzhou, > > On 30/12/2021 23:15, Martin Blumenstingl wrote: > > On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang > > <shunzhou.jiang@xxxxxxxxxxx> wrote: > >> > >> From: Shunzhou Jiang <shunzhou.jiang@xxxxxxxxxxx> > >> > >> Add support s4 Power controller. In s4, power control > >> registers are in secure domain, and should be accessed by smc. > >> > >> Signed-off-by: Shunzhou Jiang <shunzhou.jiang@xxxxxxxxxxx> > > Also here I don't have any datasheet to compare this with, so this gets my: > > Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > > > [...] > >> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), > >> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), > >> + SEC_PD(S4_GE2D, 0), > >> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), > > For the A1 SoC's UART entry we have the following comment which > > explains why we want to to be "always on": > > UART should keep working in ATF after suspend and before resume > > > > If for some reason you need to re-send this series then it would be > > great if you could add a comment above each entry with > > GENPD_FLAG_ALWAYS_ON. > > It will help others (like me) understand these SoCs better. > > Can you resend with those comments added so I can apply the patches ? > > Thanks, > Neil > > > > > > > Best regards, > > Martin > > > >