On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang <shunzhou.jiang@xxxxxxxxxxx> wrote: > > From: Shunzhou Jiang <shunzhou.jiang@xxxxxxxxxxx> > > Add support s4 Power controller. In s4, power control > registers are in secure domain, and should be accessed by smc. > > Signed-off-by: Shunzhou Jiang <shunzhou.jiang@xxxxxxxxxxx> Also here I don't have any datasheet to compare this with, so this gets my: Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> [...] > + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), > + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), > + SEC_PD(S4_GE2D, 0), > + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), For the A1 SoC's UART entry we have the following comment which explains why we want to to be "always on": UART should keep working in ATF after suspend and before resume If for some reason you need to re-send this series then it would be great if you could add a comment above each entry with GENPD_FLAG_ALWAYS_ON. It will help others (like me) understand these SoCs better. Best regards, Martin
