On Tue, Jan 11, 2022 at 01:59:18PM +0200, Cristian Pop wrote: > This adds device tree bindings for the one-bit-adc-dac. I have no idea what a one-bit-adc-dac is. Please describe or provide a reference to what this h/w looks like. > > Signed-off-by: Cristian Pop <cristian.pop@xxxxxxxxxx> > V1->V2 This belongs below the '---' > - I am aware of the recommendation of rename/move this driver. Should we > consider "drivers/io/gpio.c"? > - Add .yaml file > - Remove blank lines, remove unnecessary coma > - Remove macros for channels > - Check if channel is input for write_raw > - Use labels instead of extend_name > - Fix channel indexing > - Use "sizeof(*channels)" in devm_kcalloc() > - Remove assignment: " indio_dev->dev.parent = &pdev->dev;" > - Remove "platform_set_drvdata" > - Remove "adi" from compatible string since is not ADI specific driver. > --- > .../bindings/iio/addac/one-bit-adc-dac.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml > > diff --git a/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml b/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml > new file mode 100644 > index 000000000000..dbed0f3b1ca4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2020 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/addac/one-bit-adc-dac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices one bit ADC DAC driver > + > +maintainers: > + - Cristian Pop <cristian.pop@xxxxxxxxxx> > + > +description: | > + One bit ADC DAC driver > + > +properties: > + compatible: > + enum: > + - adi,one-bit-adc-dac > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + in-gpios: > + description: Input GPIOs > + > + out-gpios: > + description: Output GPIOs No constraints on how many GPIOs? > + > +required: > + - compatible > + - in-gpios > + - out-gpios > + > +patternProperties: > + "^channel@([0-9]|1[0-5])$": > + type: object > + description: | > + Represents the external channels which are connected to the ADDAC. > + > + properties: > + reg: > + maxItems: 1 > + description: | > + The channel number. > + > + label: > + description: | > + Unique name to identify which channel this is. > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + one-bit-adc-dac@0 { > + compatible = "one-bit-adc-dac"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + in-gpios = <&gpio 17 0>, <&gpio 27 0>; > + out-gpios = <&gpio 23 0>, <&gpio 24 0>; > + > + channel@0 { > + reg = <0>; What does '0' correspond to? > + label = "i_17"; Why is this needed? 'label' is supposed to correspond to physical labelling of ports. IOW, for identification by humans looking at the device. This all looks duplicated from information in in-gpios and out-gpios. > + }; > + > + channel@1 { > + reg = <1>; > + label = "i_27"; > + }; > + > + channel@2 { > + reg = <2>; > + label = "o_23"; > + }; > + > + channel@3 { > + reg = <3>; > + label = "o_24"; > + }; > + }; > -- > 2.17.1 > >
